Author Topic: vpdf  (Read 1768 times)

hth313

  • Newbie
  • *
  • Posts: 15
  • Karma: +0/-0
Re: vpdf
« Reply #60 on: June 09, 2019, 11:24:04 PM »
i have silenced the above complaints for convenience.

Did you do that by suppressing the warning?

If yes, just for completeness, the correct way would be to declare the struct/class member to be a 'char const*' so you get a diagnostic message if someone later attempts to actually write into it, rather than (possibly) crash at run-time (now or later).

If not, please disregard, I do not have any fix to look at(?)

wawa

  • Member
  • ***
  • Posts: 135
  • Karma: +0/-0
Re: vpdf
« Reply #61 on: June 10, 2019, 09:40:01 AM »
yes, i suppressed it for the time being, because i would like to synchronize the aros repository with the authors first. and yes, i think this is probably the fix as hinted at by gcc9, but thx anyway. hope watto corrects that.

watto

  • Newbie
  • *
  • Posts: 15
  • Karma: +0/-0
Re: vpdf
« Reply #62 on: June 10, 2019, 06:04:34 PM »
@wawa I'll be looking at your changes along with what I have and double check whether anything I think important has been lost.  I agree with you regarding retaining compatibility with MorphOS and others so will look at doing that as well as finding the source of the crash.