New Picture Datatypes

miker1264 · 2460

miker1264

  • Legendary Member
  • *****
    • Posts: 558
    • Karma: +21/-2
Reply #45 on: April 07, 2021, 04:20:37 AM
Hello again.

Update. My additions to Picture Datatype have been committed to the ABIv1 sources.

Now Save As IFF in MultiView will allow saving ILBM images.

Also two new methods "WhichPicture" and "GetNumPictures" have been added.

Maybe we can also bring this to IcarosDesktop for ABIv0.



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 304
    • Karma: +21/-0
Reply #46 on: April 07, 2021, 09:31:32 AM
I'll see if I can integrate these changes over weekend. Do I only need to bring changes from 31.03, 4.04 and 5.04?



miker1264

  • Legendary Member
  • *****
    • Posts: 558
    • Karma: +21/-2
Reply #47 on: April 07, 2021, 02:31:09 PM
@deadwood

There were changes in methods.h pictureclass.h and pictureclass.c modules. Also "STATIC" was dropped from function names. So the new function is "IPTR DT_Write".

We tested the picture datatype after committing changes. It was working well with MultiView. I will post a few test images here.

For Save As IFF it can save ILBM images with 8bitplanes and below and also 24bitplanes.



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 304
    • Karma: +21/-0
Reply #48 on: April 07, 2021, 05:06:15 PM
Where there any changes needed in Multiview? If so, when were they comitted?



miker1264

  • Legendary Member
  • *****
    • Posts: 558
    • Karma: +21/-2
Reply #49 on: April 07, 2021, 05:33:14 PM
@deadwood

MultiView automatically detects if DTWM_IFF is enabled in Picture Datatype.

But DTM_Write needs to be enabled in picture.conf file just below DT_PRINT on line 43. Add:

DTM_WRITE
.function DT_Write

If it isn't already enabled.

I was looking at your repository at:
github.com/deadwOOd/AROS
if that is the correct location for the current ABIv0 sources.

It seems DTM_WRITE is enabled. Mazze had enabled it in ABIv1 some time ago but he didn't have the Save ILBM for DT_Write. The current version of Picture Datatype for ABIv1 is 41.6 and yours is 41.5 so they are very similar. Just add the new DT_Write and two new methods (attributes). WhichPicture, GetNumPictures. DT_Write is already present at line 1604.

I included IFF Sample Images here as attached file.
You can also open 8bit or 24bit images in MultiView and Save As IFF. I can help test Picture Datatype and MultiView after you integrate the changes.
« Last Edit: April 07, 2021, 06:56:24 PM by miker1264 »



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 304
    • Karma: +21/-0
Reply #50 on: April 07, 2021, 06:37:37 PM
Ok, thanks



miker1264

  • Legendary Member
  • *****
    • Posts: 558
    • Karma: +21/-2
Reply #51 on: April 07, 2021, 06:55:40 PM
@deadwood

Is that the correct location for the current ABIv0 repository ?

github.com/deadwOOd/AROS

I see from a previous post that it is the correct location.

It may save you some effort if I simply fork your repo and make a new branch to submit a PR for changes to your Picture Datatype. I have a few other changes to submit also.
« Last Edit: April 07, 2021, 09:18:55 PM by miker1264 »



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 304
    • Karma: +21/-0
Reply #52 on: April 07, 2021, 10:14:27 PM