AROS 68k updates from ApollOS repository

deadwood · 12397

miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #195 on: December 12, 2021, 09:37:34 PM
That error indeed looks like lack of compatibility.

I'm using ABIv11 latest sources:
https://github.com/deadw00d/AROS

Once I update my sources and can compile a good ROM then I can proceed. I suspect that the GetFileSize method in ReadIconPNG fails on 68k. Why? Because I used that method in my Icon2PNG app recently and it failed on 68k. So I replaced it with a FileInfoBlock method and now it works correctly.

Once I enable debug I will check that first then write the ARGB Data to a bin file and check it's contents. I'll keep looking at it.



miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #196 on: December 13, 2021, 01:03:49 AM
@deadwood


I'm having problems with the 68k build system using sources from ABIv11.

So it ocurred to me that my source files are a little older but I have about 8 AROS 68k test configs in WinUAE.

Each one is from a different time period. I don't throw anything away!  ;)

So I matched up my newly rebuilt ROM files with the version of AROS 68k. Simple trial and error. I found a winner! Mar 3, 2020.

In addition to that I believe we fixed the problem. The MultiView Icon you see is the PNG Icon from X86_64. No tricks! It looks great. Plenty of debug information too!  :)

Maybe the new ROM fixed the problem? I don't know. But it seems they work fine with PNG Icons.

So now what?

« Last Edit: December 13, 2021, 03:50:43 AM by miker1264 »



deadwood

  • AROS Developer
  • Legendary Member
  • *****
    • Posts: 1063
    • Karma: +104/-0
Reply #197 on: December 13, 2021, 06:19:31 AM
@miker1264

What sort of problems you are having with build?

With regards to your findings, are you saying that the last working ROM is 3rd March 2020?

Here is how these icons look like on my linux-x86_64 build:



miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #198 on: December 13, 2021, 10:09:26 AM
@miker1264

What sort of problems you are having with build?

With regards to your findings, are you saying that the last working ROM is 3rd March 2020?

Here is how these icons look like on my linux-x86_64 build:

Yes. Last working ROM was Mar 3, 2020. Icons look great.

As far as build it keeps stopping searching for packages such as "cunit-3.2.6 and a few others. Maybe I should try gcc 6.5. ?



deadwood

  • AROS Developer
  • Legendary Member
  • *****
    • Posts: 1063
    • Karma: +104/-0
Reply #199 on: December 13, 2021, 10:25:22 AM
I'd propose to first do a build using the official method (./rebuild.sh script) and once that works, check other compilers :)

EDIT: I think compiler versions other then 6.5.0 won't work with ABIv11 for the moment. I didn't maintain them when making changes.
« Last Edit: December 13, 2021, 10:43:15 AM by deadwood »



AMIGASYSTEM

  • Legendary Member
  • *****
    • Posts: 2120
    • Karma: +48/-1
  • AROS One
    • AROS One
Reply #200 on: December 13, 2021, 10:54:40 AM
I did some tests these are the results

If I use my old AROS One 68k v1.1 from 2019 with deadwood's recent ROM, Dual-PNG icons show up perfectly, see screenshot (peterK's icon.library was not present in the system)

So ROMs work fine, icon.library works fine, in my opinion in 2020 something was broken


deadwood

  • AROS Developer
  • Legendary Member
  • *****
    • Posts: 1063
    • Karma: +104/-0
Reply #201 on: December 13, 2021, 11:13:07 AM
@AMIGASYSTEM

Mystery thinkens. The screen shot I made from linux-x86_64 showing wrong icons rendering is the same code base that I use for ROMs I posted. So it seems it sometimes works and sometimes does not. Can you show output of liblist showing version of icon.library when it works for you.



miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #202 on: December 13, 2021, 12:56:43 PM
@deadwood

I can verify that the latest ROM you posted does NOT work to display PNG Icon Images.

AMIGASYSTEM would have missed it since he uses PeterK's Icon Library for his latest AROS One 68k.

According to the commits log for ABIv1 there were changes to Icon Library 9 months ago.
« Last Edit: December 13, 2021, 01:07:06 PM by miker1264 »



AMIGASYSTEM

  • Legendary Member
  • *****
    • Posts: 2120
    • Karma: +48/-1
  • AROS One
    • AROS One
Reply #203 on: December 13, 2021, 01:08:17 PM
No miker I used only the icon.library that is in ROM, if you look at the screenshot you will notice that the icon.library in use on my old AROS One is v44.4 date 02 12 2021 the one inserted in the last deadwood ROM

deadwood i hope this is what you wanted to see


miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #204 on: December 13, 2021, 01:18:12 PM
AMIGASYSTEM

The change in Icon Library happened in about March 2021 about 9 months ago. If your Icon Library is from February 2021 then it's good. But the Icon Library in ABIv11 has issues as we see in deadwoods screenshot of his x86_64. So the latest ROM uses code from after the change 9 months ago.



miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #205 on: December 13, 2021, 02:17:17 PM
@deadwood

Here's a theory.

Either a change was introduced into Icon Library in the past that prevents PNG Icon Images from displaying properly or the change happened outside Icon Library.

Such as the Graphics HIDD driver, RTG driver. To narrow it down I would copy your Icon Library sources from ABIv11 into my x86_64 build system which is based on ABIv1 from 1 yr ago.



deadwood

  • AROS Developer
  • Legendary Member
  • *****
    • Posts: 1063
    • Karma: +104/-0
Reply #206 on: December 13, 2021, 02:18:27 PM
Sounds like a plan to narrow down what happened :)



miker1264

  • Legendary Member
  • *****
    • Posts: 1294
    • Karma: +82/-2
Reply #207 on: December 13, 2021, 02:50:46 PM
Sounds like a plan to narrow down what happened :)

@deadwood

I copied your Icon Library sources from ABIv11 to my x86_64 build system then recompiled it.

On the IcarosDesktop x86_64 with system files from about two years ago, mid 2019 the icons display just fine.

For the sake of the pseudo-scientific method I will repeat the process to verify the results.

So it's entirely possible that the latest ROM file you posted could work correctly on AROS One 68k from February 2021 like he said.

Apologies to AMIGASYSTEM. I didn't mean to doubt you good sir.  ;)

@deadwood

I did the easy part. I'll leave it to the master to do the hard part.

It must be graphics changes outside Icon Library at fault.  :)

If it's not a graphics driver change could it be a change in Wanderer? How would we test Wanderer changes?

Ronny Beck was making changes to update Workbook for Apollo OS. Maybe workbook is sufficiently advanced to show icons on AROS 68k? If it works it could be a problem with Wanderer.

Just a few ideas.  :)

« Last Edit: December 13, 2021, 03:15:12 PM by miker1264 »



deadwood

  • AROS Developer
  • Legendary Member
  • *****
    • Posts: 1063
    • Karma: +104/-0
Reply #208 on: December 13, 2021, 03:08:54 PM
Thanks, I'll look into this.



AMIGASYSTEM

  • Legendary Member
  • *****
    • Posts: 2120
    • Karma: +48/-1
  • AROS One
    • AROS One
Reply #209 on: December 13, 2021, 04:11:28 PM
deadwood I think I have discovered the culprit, now even your Distribution shows well the DualPNG icons with the icon.library present in ROM, as I suspected it is not the fault of your icon.library and it is not the fault of the ROM, I'll finish to do the tests and probably I'll say the culprit, I hope I was not wrong.

miker don't worry you made me do a test that confirmed what I said, given my old age I could also be wrong :)

miker IcarOS uses Dopus5 which handles icons in its own way, this could divert the study, PeterK has also fixed the icon.library for those who use Dopus Magellan.
« Last Edit: December 13, 2021, 04:14:53 PM by AMIGASYSTEM »