AROS ABIv0 20180415 Development

deadwood · 2205

salvo

  • Legendary Member
  • *****
    • Posts: 932
    • Karma: +13/-4
  • Invalid Civil
Reply #45 on: April 13, 2021, 08:44:40 PM
works fine, i opened multiview and show an image



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #46 on: April 13, 2021, 09:38:01 PM
works fine, i opened multiview and show an image

If it's 8bit or less or if it's 24bit can you Save As IFF ?

That's the test.



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #47 on: April 13, 2021, 09:40:50 PM
@deadwood

The size of the ILBM images are different because the originals use RLE compression. The saved images are Uncompressed.

You may also open a jpeg and Save As IFF.

I changed my editor settings to 4 spaces instead of 8 spaces. Unfortunately I use Scintilla Text Editor and it keeps reverting.
« Last Edit: April 13, 2021, 10:55:10 PM by miker1264 »



salvo

  • Legendary Member
  • *****
    • Posts: 932
    • Karma: +13/-4
  • Invalid Civil
Reply #48 on: April 13, 2021, 10:14:20 PM
ok works fine, i have saved a 24 bit image :)



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 326
    • Karma: +22/-0
Reply #49 on: April 14, 2021, 06:43:22 AM
@deadwood

The size of the ILBM images are different because the originals use RLE compression. The saved images are Uncompressed.

You may also open a jpeg and Save As IFF.

Can you check the ISO I published if everything works as it should?

I changed my editor settings to 4 spaces instead of 8 spaces. Unfortunately I use Scintilla Text Editor and it keeps reverting.
Please then convert tabs to 4 spaces before pushing your changes. We are avoiding tabs in source code as everyone editor interprets tabs differently and this makes source code created by one person hard to read by another one.



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #50 on: April 14, 2021, 07:18:50 PM
I downloaded the ISO yesterday.

I tested with 8bit and 24bit. Save As IFF in MultiView worked. I'm satisfied that it's functional.

Thank you for bringing the picture datatype changes to ABIv0. After all this time...now MultiView can save ILBM image files.

I will revise the 4 space indents on my DT_Write and remove unused variables. 



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 326
    • Karma: +22/-0
Reply #51 on: April 14, 2021, 09:37:55 PM
Great! I'm happy it works and it now available to everyone for use :)



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #52 on: April 14, 2021, 11:39:05 PM
deadwood

Did you upload the changes for picture datatype to the Alt-ABIv0 repository yet? I didn't see any changes.



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 326
    • Karma: +22/-0
Reply #53 on: April 15, 2021, 06:15:32 AM
It's pushed now :)



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #54 on: April 15, 2021, 04:25:25 PM
deadwood

Thank you, sir. I mainly wanted to compare my version with yours to find out which unused variables to delete and how to format it correctly. I was going to submit changes to ABIv1.

I will leave the picture datatype for ABIv1 as it is atm. Thank you for helping with Picture Datatype. Now AROS users may benefit.

I'm going to go do some spring gardening and some other tasks I have been saving till later.
« Last Edit: April 15, 2021, 05:01:37 PM by miker1264 »



deadwood

  • AROS Developer
  • Senior Member
  • *****
    • Posts: 326
    • Karma: +22/-0
Reply #55 on: April 15, 2021, 06:52:49 PM
Great. Spring gardering is the best :)

If you have more improvements in future, push them to AROS repository and I'll grab it from there or push it on top of my repository master (not that it is 6 months behind AROS repo at the moment).



miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #56 on: April 15, 2021, 07:18:39 PM
deadwood

I have been deleted from the ABIv1 Slack Channel because of a disagreement with a lead developer. I may not be able to commit changes to ABIv1. I'm a renegade now! I'm on my own.

How would I submit a PR or submit changes to your Alt-ABIv0 repo? Isn't It a Fork with branches? I'm not very good with GitHub.

I do have more changes to help support IcarosDesktop. I'll compare your changes for picture datatype to my copy and update it for my records.

I don't know how you feel about this. I made some changes to my copy of MultiView. I was calling it SuperMultiView because it wasn't allowed to be part of AROS because it added Save As PNG as well as Save As IFF. I wanted to update MultiView. Someone on this list, maybe Yannick, asked if MultiView could print a list of datatypes and their methods. Why not? Seems ok.

I will probably have some changes for Lunapaint in the next few weeks. I added several functions for saving with dataypes and automatic bitdepth conversion. I'm also adding color quantizing. That will take at least a week to understand the quantizer code.

« Last Edit: April 15, 2021, 07:49:48 PM by miker1264 »



nikos

  • Senior Member
  • ****
    • Posts: 298
    • Karma: +8/-2
    • aspireos
Reply #57 on: April 16, 2021, 04:32:30 PM
miker1264: Great work :) Looking forward to test your updates.


miker1264

  • Legendary Member
  • *****
    • Posts: 627
    • Karma: +26/-2
Reply #58 on: April 16, 2021, 05:02:52 PM
Thank you nikos.

deadwood

I can upload my MultiView sources here or send them to you directly. The source code is a little messy. It's my working copy.

For Save As PNG there is a new menu item. It uses DoWriteMethod_PNG which receives dto then it gets a new empty png datatype. It copies all the data to ndto then writes to file using DTWM_RAW.

I find it very useful to simply double-click an image to open in MultiView then Save As PNG. When the only option is Save As IFF it makes it difficult to transfer the file to Photoshop or Paint.



salvo

  • Legendary Member
  • *****
    • Posts: 932
    • Karma: +13/-4
  • Invalid Civil
Reply #59 on: April 16, 2021, 05:52:39 PM
miker if you welcome us even if you sorry what happened, everyone does the possible here ;)